MediaWiki talk:Gadget-GlobalRenameQueueCheckAntiSpoof.js

Add topic
From Meta, a Wikimedia project coordination wiki
Latest comment: 2 years ago by Steinsplitter in topic (warning|error)box

@Rxy: Could this gadget ignore cases, when the conflict is with the user itself (Special:GlobalRenameQueue/request/54739, DrJenniferMirembe wanted to be renamed to Dr Jennifer Mirembe, which antispoof detects as conflict with DrJenniferMirembe, and also display antispoof results somewhere? Thanks! --Martin Urbanec (talk) 10:59, 1 August 2019 (UTC)Reply

hmm. sure. I'll do that later.. --rxy (talk) 09:48, 6 August 2019 (UTC)Reply
Thanks. --Martin Urbanec (talk) 10:37, 6 August 2019 (UTC)Reply
Done Implemented.--rxy (talk) 05:36, 7 August 2019 (UTC)¨Reply
Thank you! --Martin Urbanec (talk) 12:36, 7 August 2019 (UTC)Reply

@Rxy: This also caused phab:T224485. --Martin Urbanec (talk) 16:16, 5 August 2019 (UTC)Reply

That case is work as expect for my environment. The ticket author wants return to Special:GlobalRenameQueue/open when clicking dialog cancel button?--rxy (talk) 09:48, 6 August 2019 (UTC)Reply
Well, if you click "Cancel", it proceeds with the rename. --Martin Urbanec (talk) 10:37, 6 August 2019 (UTC)Reply
Done Implemented by Special:Preferences#mw-prefsection-gadgets (MediaWiki:Gadget-GlobalRenameQueueCheckAntiSpoof-variable-leaveByDialogCancel.js).--rxy (talk) 05:36, 7 August 2019 (UTC) del --rxy (talk) 06:10, 7 August 2019 (UTC)Reply
Fixed by Special:Diff/19269516 --rxy (talk) 06:10, 7 August 2019 (UTC)Reply
Thank you! --12:36, 7 August 2019 (UTC)

(warning|error)box[edit]

@@ -91,13 +91,13 @@
 						    		'<div>',
 						    		{
 						    			id: 'EXT_rxy_antispoof_error',
-						    			class: 'errorbox',
+						    			class: 'mw-message-box mw-message-box-error',
 						    			text: '[AntiSpoof] ' + data.antispoof.error
 						    		}
 								).append( $apiLink ).append( enableButton.$element )
 						    );
 						} else if ( data.antispoof.result == 'conflict' ){
-							var conflictDivClass = 'errorbox';
+							var conflictDivClass = 'mw-message-box mw-message-box-error';
 							var conflictTextSuffix = '.';
 							var requesterUsername = $(
 								$( '#mw-globalrenamequeue-request label > ul > li' )[0]
@@ -106,7 +106,7 @@
 								data.antispoof.users.length === 1
 								&& data.antispoof.users[0] === requesterUsername
 							) {
-								conflictDivClass = 'warningbox';
+								conflictDivClass = 'mw-message-box mw-message-box-warning';
 								conflictTextSuffix = ", but same with requester's username.";
 								enableApproveButton( $approveButton );
 								enableButton.$element = null;

Part of the phab:T300306. Stang 20:48, 15 April 2022 (UTC)Reply

Done. --Steinsplitter (talk) 15:13, 23 April 2022 (UTC)Reply